Factor our service client creation [Finishes #114442535] [Finishes 114106051] [Finishes 114420495]

…zure#16)

* Support for zoned public IP. Make global zone_type and zones_type.

* Code review feedback.

* Initial support for VM and single zone VMSS (#14)

* wire up the initial zone support work

* add output

* add tests

* disable package verifications

* use a private copy of network sdk with zone support (#15)

* Support for zoned public IP. Make global zone_type and zones_type. (#16)

* Support for zoned public IP. Make global zone_type and zones_type.

* Code review feedback.

* apply api version range on vm zone test (#19)

* show zone in the table output (#20)

* install: support to build out a msi installer from local sources (#17)

* doc:add command examples using availability zones (#21)

* Installer: build debian bundle from a local clone (#28)

* skip a few expeneive travis builds

* test: update tests to work with new azure-mgmt-compute with zone support

* network: support zone in network lb create (#37)

* VNet peering examples. (#51)

* Add BrazilUS and Dogfood cloud config files. (#50)

* undo all changes specifically for private repository

* fix help per review feedback

* fix lint error

* use newer nrp sdk version

Users/rajsell/reset password

- License check: Handle \r\n and \n
- Index check: Reject https://pypi.python.org urls
- Source tests: Install extension in its own dir before running test for extension

* NFSAAS-1708 add initial version of anf cli extension

* NFSAAS-1708 lint fixes

* NFSAAS-1708 code owner

* NFSAAS-1708 update from review comments

* NFSAAS-1708 update from review comments

* NFSAAS-1708 update with code review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments (Azure#9)

* Nfsaas 1708 initial cli extension (Azure#10)

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* Nfsaas 1708 initial cli extension (Azure#11)

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* Nfsaas 1708 initial cli extension (Azure#13)

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* Nfsaas 1708 initial cli extension (Azure#14)

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* Nfsaas 1708 initial cli extension (Azure#16)

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* Nfsaas 1708 initial cli extension (Azure#17)

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 add initial version of anf cli extension

* NFSAAS-1708 lint fixes

* NFSAAS-1708 code owner

* NFSAAS-1708 update from review comments

* NFSAAS-1708 update from review comments

* NFSAAS-1708 update with code review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments (Azure#9)

* Nfsaas 1708 initial cli extension (Azure#10)

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* Nfsaas 1708 initial cli extension (Azure#11)

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* Nfsaas 1708 initial cli extension (Azure#13)

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* Nfsaas 1708 initial cli extension (Azure#14)

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* Nfsaas 1708 initial cli extension (Azure#16)

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* Nfsaas 1708 initial cli extension (Azure#17)

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 add anf to cli extension index

* NFSAAS-1708 add anf to cli extension index (Azure#18)

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index (Azure#22)

Plus correct some help validation errors

* Nfsaas 1708 add index (Azure#23)

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* Nfsaas 1708 add index (Azure#24)

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* Nfsaas 1708 add index (Azure#25)

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* Nfsaas 1708 add index (Azure#26)

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* Nfsaas 1708 add index (Azure#27)

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* Azure quantum extension v0 (Azure#2)

Initial version.

* Fixing style issues

* Incorporating feedback (Azure#6)

* readme
* feedback

* Help

* Make storage account optional (Azure#7)

* Storage is now optional (Azure#8)

* Making storage an argument, not an env variable (Azure#9)

* Adding implementation of 'az quantum workspace delete' command.

* Setting new temporary version.

* Fixing missing file in test change

* Adding details to README.md (Azure#5)

* Updating generated files for Azure Quantum resource manager from new swagger file version

* Remove manual edit of generated file.

* Updating generated files for Azure Quantum data plane from new swagger file version

* Updating generated files for Azure Quantum resource manager from new swagger file version. (2020-11-06) (Azure#13)

* Adding implementation of 'az quantum workspace create' command. (Azure#14)

Adding initial implementation of 'az quantum workspace create' command.

-----------------------------------
Command
az quantum workspace create : Creates a new Azure Quantum workspace.
Command group 'quantum' is in preview. It may be changed/removed in a future
release.
Arguments
--location -l : Location. Values from: az account list-locations. You can configure
the default location using az configure --defaults location=<location>.
--resource-group -g : Name of resource group. You can configure the default group using az configure --defaults group=<name>.
--storage_account -sa : Name of the storage account to be used by a quantum workspace.
--workspace-name -w : Name of the Quantum Workspace. You can configure the default workspace
using az quantum workspace set.

* Update Azure CLI quantum extension to multi-region (Azure#17)

This change will set the URL for the data plan API accordingly with a location parameter specified as part of the command.

* Updating swagger files per commit 44563991425d862ba4e8090a2b5b6caf8333600c in azure-rest-api-specs-pr. (Azure#16)

Updating swagger files per commit 44563991425d862ba4e8090a2b5b6caf8333600c in azure-rest-api-specs-pr.

* Fixing tests for multi-region URL change on Az CLI quantum extension (Azure#19)

Fixing tests for multi-region URL change on Az CLI quantum extension

* Incorporating ARM feedback  (Azure#18)

* Picking up latest changes from swagger after ARM feedback

* updated create_or_update

* run command

* Setting default location in workspace calls if not specified (Azure#20)

* updating python azure quantum rest client (Azure#21)

* Update generated files from swagger file (Version 2021-01-11) (Azure#22)

* Hot fixes on December 2020 release of Azure CLI extension (Azure#23)

* Fixing issue with over specification of location
* Updating version information of extension

* Update CLI with generated clients from more recent swagger files (Azure#24)

- Data plane updated to official swagger file (2021-01-11 19:01:32 UTC) on azure-rest-api-specs @ 98ae52b87af2f172f84f3305f8fe46f819543a49.

- Resource manager updated to candidate swagger file (2021-01-15 19:35:41 UTC) on anpaz:quantum/resource-manager @ a9a9e271c13500aa54fdbb1bcb656eb61d82d38b.

* Update src/quantum/README.rst

Co-authored-by: Feiyue Yu <[email protected]>

* Update src/quantum/README.rst

Co-authored-by: Feiyue Yu <[email protected]>

* Update src/quantum/README.rst

Co-authored-by: Feiyue Yu <[email protected]>

* Update src/quantum/README.rst

Co-authored-by: Feiyue Yu <[email protected]>

* Require location as a mandatory parameter in workspace specification (Azure#25)

* Make location mandatory in commands
* Update test recordings

* Resetting the version history for the released version.

* Fix description of workspace clear command

* Updatig Readme file to RST format.

* Update Readme file per pull request comments.

* Fixing az quantum run and execute commands to include location parameter

* Performing role assignment on storage account on workspace creation. (Azure#29)

* Add warning message about providers during workspace creation (Azure#30)

* Enable command az quantum workspace quotas (Azure#31)

* Removing extra space in Readme.rst

Co-authored-by: Feiyue Yu <[email protected]>

* Fix punctuation in Readme.rst

Co-authored-by: Feiyue Yu <[email protected]>

* Update src/quantum/README.rst

Co-authored-by: Feiyue Yu <[email protected]>

* Update src/quantum/azext_quantum/_params.py

Co-authored-by: Feiyue Yu <[email protected]>

* First round of code review feedback on Readme.rst

* Improve code readability on job commands

* Avoid IndexError in case of malformed URL

* Extended info on targetId parameter

* Add help to each individual command

* Reorganize sections in Readme.rst and merge in a single set of instructions.

* Static analysis fixes

* Fix CLI Linter errors

* Fix CLI Linter errors. Part 2

* Fix typo in show command.

* Fix show command for Linter

* Use standard name for show command method

* Modify workspace create test to skip role assignment

* Update tests with workspace names used currently.

* Update test recordings.

* Set subscription for the recordings.

* Update test recordings.

* Update QDK version number

* Remove asserts and checks for subscription

* Experiment: Remove check for preview subscription

* Refresh recordings with current test values.

* Update recordings after typo fix.

* Remove commented out API that references subscription

* Enable QuantumJobsScenarioTest.test_submit_args only on live mode

Co-authored-by: Ricardo Espinoza <[email protected]>
Co-authored-by: Feiyue Yu <[email protected]>

Fixed incorrect method name in orchestrator when calling ConnectivityTester.

Error:
  AttributeError: 'ConnectivityTester' object has no attribute 'run_connectivity_tests'

Root cause:
  orchestrator.py calling connectivity_tester.run_connectivity_tests(resource_group_name)
  but correct method is test_connectivity(enable_probes=bool)

Fix:
  - Changed method call from run_connectivity_tests() to test_connectivity()
  - Updated parameter from resource_group_name to enable_probes=True
  - Matches actual ConnectivityTester API signature

Testing:
  az aks net-diagnostics -n aks-overlay -g aks-overlay-rg --probe-test ✓

Bug Azure#16: Connectivity tester method name mismatch

Updated PHASE6-PROGRESS.md with complete test results for Category 1:
Basic Execution Tests.

Tests Completed (6/6):
- Test 1.1: Basic execution ✅
- Test 1.2: --details flag ✅
- Test 1.3: --json-report flag ✅
- Test 1.4: --probe-test flag ✅
- Test 1.5: Combined flags (--details --json-report) ✅
- Test 1.6: All flags combined ✅

Bug Azure#16 Added:
- Connectivity tester method name mismatch
- Fixed incorrect method call (run_connectivity_tests → test_connectivity)

Updated Statistics:
- Total Bugs Found: 16
- Total Bugs Fixed: 16
- Success Rate: 100%
- Total Commits: 11
- Category 1: COMPLETE (6/6 tests passed)

All basic execution scenarios validated successfully.

Fixed incorrect method name in orchestrator when calling ConnectivityTester.

Error:
  AttributeError: 'ConnectivityTester' object has no attribute 'run_connectivity_tests'

Root cause:
  orchestrator.py calling connectivity_tester.run_connectivity_tests(resource_group_name)
  but correct method is test_connectivity(enable_probes=bool)

Fix:
  - Changed method call from run_connectivity_tests() to test_connectivity()
  - Updated parameter from resource_group_name to enable_probes=True
  - Matches actual ConnectivityTester API signature

Testing:
  az aks net-diagnostics -n aks-overlay -g aks-overlay-rg --probe-test ✓

Bug Azure#16: Connectivity tester method name mismatch

Updated PHASE6-PROGRESS.md with complete test results for Category 1:
Basic Execution Tests.

Tests Completed (6/6):
- Test 1.1: Basic execution ✅
- Test 1.2: --details flag ✅
- Test 1.3: --json-report flag ✅
- Test 1.4: --probe-test flag ✅
- Test 1.5: Combined flags (--details --json-report) ✅
- Test 1.6: All flags combined ✅

Bug Azure#16 Added:
- Connectivity tester method name mismatch
- Fixed incorrect method call (run_connectivity_tests → test_connectivity)

Updated Statistics:
- Total Bugs Found: 16
- Total Bugs Fixed: 16
- Success Rate: 100%
- Total Commits: 11
- Category 1: COMPLETE (6/6 tests passed)

All basic execution scenarios validated successfully.